Skip to content

Disable CSS font ligatures from admin UI#695

Merged
colinmegill merged 1 commit intocompdemocracy:devfrom
patcon:695-no-ligatures
May 14, 2021
Merged

Disable CSS font ligatures from admin UI#695
colinmegill merged 1 commit intocompdemocracy:devfrom
patcon:695-no-ligatures

Conversation

@patcon
Copy link
Copy Markdown
Contributor

@patcon patcon commented May 14, 2021

Screen Shot 2020-12-15 at 9 42 49 PM

"fi" seem to be automatically merging into a single character. I knew this happened in some coding/math fonts, but didn't realize it could happy in the browser.

https://stackoverflow.com/a/47063000/504018

@colinmegill
Copy link
Copy Markdown
Member

image

@colinmegill
Copy link
Copy Markdown
Member

@patcon
Copy link
Copy Markdown
Contributor Author

patcon commented Dec 16, 2020

Screen Shot 2020-12-15 at 11 48 20 PM

As referenced in StackOverflow link, something like this resolves it (confirmed via inspector):

* {
  font-variant-ligatures: none;
}

EDIT: Feel free to +1 this about the fix googlefonts/spacemono#2

EDIT2: heh, and another in </ and fl:

Screen Shot 2020-12-15 at 11 57 18 PM

@patcon
Copy link
Copy Markdown
Contributor Author

patcon commented May 14, 2021

This small PR should resolve this issue. Maybe there's a more theme-ui way to apply CSS globally, but I wasn't sure what it was, so just added this in index.html alongside the google font import 😃

Production

Screen Shot 2021-05-13 at 11 55 01 PM

This PR

Screen Shot 2021-05-13 at 11 54 54 PM

@colinmegill colinmegill merged commit 110c567 into compdemocracy:dev May 14, 2021
@colinmegill
Copy link
Copy Markdown
Member

Looks great! Thanks @patcon! 🎉

raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Sep 1, 2021
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Oct 26, 2021
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants